DevTools: Add a shortcut for switching between files with the same name and different extensions.

DevTools: Add a shortcut for switching between files with the same name and different extensions.

R=pfeldman, lushnikov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178054

[apavlov, 2014-07-09 14:06:06]

lgtm with nits

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/components/ShortcutsScreen.js (right):

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/components/ShortcutsScreen.js:272:
section.addAlternateKeys(WebInspector.shortcutRegistry.shortcutDescriptorsForAction("sources.switch-file"),
WebInspector.UIString("Switch between files with the same name an ddifferent
extensions."));
typo: "an ddifferent" -> "and different"

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/sources/SourcesView.js (right):

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/SourcesView.js:706: var namePrefix =
name.substr(0, name.indexOf(".")) + ".";
var namePrefix = name.substr(0, name.indexOf(".") + 1);

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/SourcesView.js:709: var uiSourceCode =
uiSourceCodes[i]
';' missing

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/SourcesView.js:714: var index =
mod(candidates.indexOf(name) + 1, candidates.length);
Do we want to be able to set up certain switching sequences, like cc|cpp <->
h|hpp?

[lushnikov, 2014-07-11 11:39:53]

On 2014/07/09 14:06:06, apavlov wrote:
> lgtm with nits
> 
>
https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
> File Source/devtools/front_end/components/ShortcutsScreen.js (right):
> 
>
https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
> Source/devtools/front_end/components/ShortcutsScreen.js:272:
>
section.addAlternateKeys(WebInspector.shortcutRegistry.shortcutDescriptorsForAction("sources.switch-file"),
> WebInspector.UIString("Switch between files with the same name an ddifferent
> extensions."));
> typo: "an ddifferent" -> "and different"
> 
>
https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
> File Source/devtools/front_end/sources/SourcesView.js (right):
> 
>
https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
> Source/devtools/front_end/sources/SourcesView.js:706: var namePrefix =
> name.substr(0, name.indexOf(".")) + ".";
> var namePrefix = name.substr(0, name.indexOf(".") + 1);
> 
>
https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
> Source/devtools/front_end/sources/SourcesView.js:709: var uiSourceCode =
> uiSourceCodes[i]
> ';' missing
> 
>
https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
> Source/devtools/front_end/sources/SourcesView.js:714: var index =
> mod(candidates.indexOf(name) + 1, candidates.length);
> Do we want to be able to set up certain switching sequences, like cc|cpp <->
> h|hpp?

let's land this?

[lushnikov, 2014-07-11 11:47:39]

lgtm

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/sources/SourcesView.js (right):

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/SourcesView.js:706: var namePrefix =
name.substr(0, name.indexOf(".")) + ".";
Let's get lastIndexOf

[apavlov, 2014-07-11 11:49:54]

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/sources/SourcesView.js (right):

https://codereview.chromium.org/378273004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/SourcesView.js:706: var namePrefix =
name.substr(0, name.indexOf(".")) + ".";
On 2014/07/11 11:47:38, lushnikov wrote:
> Let's get lastIndexOf

+1
So, var namePrefix = name.substr(0, name.lastIndexOf(".") + 1);

[apavlov, 2014-07-11 11:50:45]

I'd love to see a test here, as the functionality is non-trivial

[apavlov, 2014-07-14 08:58:26]

Thanks. LGTM

[vsevik, 2014-07-14 11:20:36]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-07-14 11:20:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vsevik@chromium.org/378273004/30001

[commit-bot: I haz the power, 2014-07-14 13:08:44]

Change committed as 178054

[paulirish1, 2014-07-14 20:23:28]

Is there an actual shortcut assigned to this right now?

[lushnikov, 2014-07-15 09:02:24]

On 2014/07/14 20:23:28, paulirish1 wrote:
> Is there an actual shortcut assigned to this right now?

Alt-O