Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: device/media_transfer_protocol/media_transfer_protocol_daemon_client.h

Issue 378263002: Devices: Remove MTP functions that use file paths. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/media_transfer_protocol/media_transfer_protocol_daemon_client.h
===================================================================
--- device/media_transfer_protocol/media_transfer_protocol_daemon_client.h (revision 281682)
+++ device/media_transfer_protocol/media_transfer_protocol_daemon_client.h (working copy)
@@ -54,16 +54,16 @@
// A callback to handle the result of CloseStorage.
typedef base::Closure CloseStorageCallback;
- // A callback to handle the result of ReadDirectoryByPath/Id.
+ // A callback to handle the result of ReadDirectoryById.
// The argument is a vector of file entries.
typedef base::Callback<void(const std::vector<MtpFileEntry>& file_entries)
> ReadDirectoryCallback;
- // A callback to handle the result of ReadFileChunkByPath/Id.
+ // A callback to handle the result of ReadFileChunkById.
// The argument is a string containing the file data.
typedef base::Callback<void(const std::string& data)> ReadFileCallback;
- // A callback to handle the result of GetFileInfoByPath/Id.
+ // A callback to handle the result of GetFileInfoById.
// The argument is a file entry.
typedef base::Callback<void(const MtpFileEntry& file_entry)
> GetFileInfoCallback;
@@ -104,13 +104,6 @@
const CloseStorageCallback& callback,
const ErrorCallback& error_callback) = 0;
- // Calls ReadDirectoryByPath method. |callback| is called after the method
- // call succeeds, otherwise, |error_callback| is called.
- virtual void ReadDirectoryByPath(const std::string& handle,
- const std::string& path,
- const ReadDirectoryCallback& callback,
- const ErrorCallback& error_callback) = 0;
-
// Calls ReadDirectoryById method. |callback| is called after the method
// call succeeds, otherwise, |error_callback| is called.
// |file_id| is a MTP-device specific id for a file.
@@ -119,18 +112,6 @@
const ReadDirectoryCallback& callback,
const ErrorCallback& error_callback) = 0;
- // Calls ReadFileChunkByPath method. |callback| is called after the method
- // call succeeds, otherwise, |error_callback| is called.
- // |bytes_to_read| cannot exceed 1 MiB.
- virtual void ReadFileChunkByPath(const std::string& handle,
- const std::string& path,
- uint32 offset,
- uint32 bytes_to_read,
- const ReadFileCallback& callback,
- const ErrorCallback& error_callback) = 0;
-
- // TODO(thestig) Remove this in the near future if we don't see anyone using
- // it.
// Calls ReadFilePathById method. |callback| is called after the method call
// succeeds, otherwise, |error_callback| is called.
// |file_id| is a MTP-device specific id for a file.
@@ -142,13 +123,6 @@
const ReadFileCallback& callback,
const ErrorCallback& error_callback) = 0;
- // Calls GetFileInfoByPath method. |callback| is called after the method
- // call succeeds, otherwise, |error_callback| is called.
- virtual void GetFileInfoByPath(const std::string& handle,
- const std::string& path,
- const GetFileInfoCallback& callback,
- const ErrorCallback& error_callback) = 0;
-
// Calls GetFileInfoById method. |callback| is called after the method
// call succeeds, otherwise, |error_callback| is called.
// |file_id| is a MTP-device specific id for a file.

Powered by Google App Engine
This is Rietveld 408576698