Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 378243002: Revert of Connect X11 ConfigureNotify events to Mojo (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Connect X11 ConfigureNotify events to Mojo (https://codereview.chromium.org/354933002/) Reason for revert: http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/14776/steps/mojo_view_manager_unittests/logs/SetNodeBounds [ FAILED ] ViewManagerTest.SetNodeBounds (109 ms) Original issue's description: > Connect X11 ConfigureNotify events to Mojo > > This change plumbs top level window resize notifications from X11 through to the WindowManager and to the GLSurface associated with the top level window. It's an incremental step towards adding support for window manager level layout management (see crbug.com/389785). > > There's preliminary X11 Support for --start-fullscreen (don't try this) and --start-maximized command line arguments as well. This part of the patch could be broken out. > > > BUG=388524 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281955 TBR=ben@chromium.org,sky@chromium.org,jamesr@chromium.org,hansmuller@chromium.org NOTREECHECKS=true NOTRY=true BUG=388524 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -133 lines) Patch
M mojo/examples/window_manager/window_manager.cc View 4 chunks +2 lines, -38 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.h View 3 chunks +0 lines, -7 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_x11.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M mojo/services/view_manager/node.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/view_manager/node_delegate.h View 2 chunks +0 lines, -8 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/services/view_manager/window_tree_host_impl.cc View 3 chunks +1 line, -45 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
horo
Created Revert of Connect X11 ConfigureNotify events to Mojo
6 years, 5 months ago (2014-07-09 07:22:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/378243002/1
6 years, 5 months ago (2014-07-09 07:23:44 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 07:24:59 UTC) #3
Message was sent while issue was closed.
Change committed as 281981

Powered by Google App Engine
This is Rietveld 408576698