Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: content/renderer/render_view_impl_android.cc

Issue 378233002: [Android] Extend smart clip to return html along with text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl_android.cc
diff --git a/content/renderer/render_view_impl_android.cc b/content/renderer/render_view_impl_android.cc
index de6fa2d2790a33511b7daeb86643de9d60b8b5ec..e30f393a58e9b50217ae2b361cb794f9d39026df 100644
--- a/content/renderer/render_view_impl_android.cc
+++ b/content/renderer/render_view_impl_android.cc
@@ -68,8 +68,9 @@ void RenderViewImpl::OnExtractSmartClipData(const gfx::Rect& rect) {
blink::WebString clip_text;
blink::WebRect clip_rect;
webview()->getSmartClipData(rect, clip_text, clip_rect);
+ blink::WebString clip_html = webview()->extractSmartClipDataAsMarkup(rect);
Yaron 2014/07/09 23:08:14 can this not be done in the previous call?
Changwan Ryu 2014/07/10 01:20:30 Fixed by extending getSmartClipData. However, chan
Send(new ViewHostMsg_SmartClipDataExtracted(
- routing_id_, clip_text, clip_rect));
+ routing_id_, clip_text, clip_html, clip_rect));
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698