Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 378233002: [Android] Extend smart clip to return html along with text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 55699754ff3356021679a8d685196b545be7f307..b937159804bd08289d79436759ebf18ee7bae303 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -1635,16 +1635,18 @@ bool ContentViewCoreImpl::WillHandleDeferAfterResponseStarted() {
}
void ContentViewCoreImpl::OnSmartClipDataExtracted(
- const gfx::Rect& clip_rect,
- const base::string16& result) {
+ const base::string16& text,
+ const base::string16& html,
+ const gfx::Rect& clip_rect) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
if (obj.is_null())
return;
+ ScopedJavaLocalRef<jstring> jtext = ConvertUTF16ToJavaString(env, text);
+ ScopedJavaLocalRef<jstring> jhtml = ConvertUTF16ToJavaString(env, html);
ScopedJavaLocalRef<jobject> clip_rect_object(CreateJavaRect(env, clip_rect));
- ScopedJavaLocalRef<jstring> jresult = ConvertUTF16ToJavaString(env, result);
Java_ContentViewCore_onSmartClipDataExtracted(
- env, obj.obj(), jresult.obj(), clip_rect_object.obj());
+ env, obj.obj(), jtext.obj(), jhtml.obj(), clip_rect_object.obj());
}
void ContentViewCoreImpl::WebContentsDestroyed() {

Powered by Google App Engine
This is Rietveld 408576698