Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 378213002: [SyncFS] Implement GetFileTrackerIDsByParent (Closed)

Created:
6 years, 5 months ago by peria
Modified:
6 years, 5 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Implement GetFileTrackerIDsByParent BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDiskTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282578

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Introduce enum NumEntries #

Total comments: 2

Patch Set 3 : Work for a nit #

Messages

Total messages: 8 (0 generated)
peria
PTL. Or should I split it into two CLs?
6 years, 5 months ago (2014-07-11 03:41:59 UTC) #1
tzik
https://codereview.chromium.org/378213002/diff/100001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h (right): https://codereview.chromium.org/378213002/diff/100001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h#newcode153 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:153: // Entries for |tracker_id| are not counted in. Can ...
6 years, 5 months ago (2014-07-11 04:21:29 UTC) #2
peria
https://codereview.chromium.org/378213002/diff/100001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h (right): https://codereview.chromium.org/378213002/diff/100001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h#newcode153 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:153: // Entries for |tracker_id| are not counted in. On ...
6 years, 5 months ago (2014-07-11 04:30:58 UTC) #3
tzik
lgtm https://codereview.chromium.org/378213002/diff/120001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h (right): https://codereview.chromium.org/378213002/diff/120001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h#newcode158 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:158: // Entries for |tracker_id| are not counted in. ...
6 years, 5 months ago (2014-07-11 04:46:02 UTC) #4
peria
https://codereview.chromium.org/378213002/diff/120001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h (right): https://codereview.chromium.org/378213002/diff/120001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h#newcode158 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:158: // Entries for |tracker_id| are not counted in. On ...
6 years, 5 months ago (2014-07-11 04:49:15 UTC) #5
peria
The CQ bit was checked by peria@chromium.org
6 years, 5 months ago (2014-07-11 04:49:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/378213002/140001
6 years, 5 months ago (2014-07-11 04:50:50 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 07:22:16 UTC) #8
Message was sent while issue was closed. 
Change committed as 282578

Powered by Google App Engine
This is Rietveld 408576698