Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 3782012: Merge 62820 - Implement IME for Mac plugins using the Cocoa event model on 10... (Closed)

Created:
10 years, 2 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, ben+cc_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Merge 62820 - Implement IME for Mac plugins using the Cocoa event model on 10.6 Based on the implementation of Gecko's Cocoa event model IME handling on 64-bit, but modified to fit Chrome's cross-process event handling. Because NSTextInputContext is 10.6+, 10.5 will need a cempletely different implementation. BUG=30905 TEST=Plugins implementing the updated NPAPI Cocoa IME spec should handle IME on 10.6. Review URL: http://codereview.chromium.org/3808001 TBR=stuartmorgan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -12 lines) Patch
M chrome/browser/renderer_host/render_widget_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 8 chunks +75 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 3 chunks +19 lines, -0 lines 0 comments Download
A + third_party/mozilla/ComplexTextInputPanel.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/ComplexTextInputPanel.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/mozilla/README.chromium View 1 chunk +11 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 3 chunks +8 lines, -9 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_mac.mm View 7 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
stuartmorgan
10 years, 2 months ago (2010-10-16 17:55:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698