Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py - Issue 378113003: Modifications to layout test framework so that it can work with browser_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

Issue 378113003: Modifications to layout test framework so that it can work with browser_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed browser test driver unittests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py b/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

index f65b682fea8a8d1e1f1c13f0fda30331da23efb3..c8acbe8783b87ec8b2f48cc6d553466e4fcfe60b 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

@@ -220,7 +220,7 @@ class DriverTest(unittest.TestCase):

port = TestWebKitPort()

port._server_process_constructor = MockServerProcess

driver = Driver(port, 0, pixel_tests=True)

- driver.start(True, [])

+ driver.start(True, [], None)

last_tmpdir = port._filesystem.last_tmpdir

self.assertNotEquals(last_tmpdir, None)

driver.stop()

@@ -230,7 +230,7 @@ class DriverTest(unittest.TestCase):

port = TestWebKitPort()

port._server_process_constructor = MockServerProcess

driver = Driver(port, 0, pixel_tests=True)

- driver.start(True, [])

+ driver.start(True, [], None)

last_tmpdir = port._filesystem.last_tmpdir

driver._start(True, [])

self.assertFalse(port._filesystem.isdir(last_tmpdir))

@@ -239,5 +239,5 @@ class DriverTest(unittest.TestCase):

port = TestWebKitPort()

port._server_process_constructor = MockServerProcess

driver = Driver(port, 0, pixel_tests=True)

- driver.start(True, [])

+ driver.start(True, [], None)

self.assertTrue(driver._server_process.started)

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/driver.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/factory.py » ('j') | no next file with comments »