Modifications to layout test framework so that it can work with browser_tests.

Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

 # Copyright (C) 2014 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
 # in the documentation and/or other materials provided with the
 # distribution.
-#     * Neither the name of Google Inc. nor the names of its
+#     * Neither the Google name nor the names of its

[Dirk Pranke, 2014/07/17 00:31:15]

this is an odd diff ...

[ivandavid, 2014/07/17 03:04:47]

O_o ... I don't know how that happened.

[ivandavid, 2014/07/17 03:04:47]

Done.

 # contributors may be used to endorse or promote products derived from
 # this software without specific prior written permission.
 #
 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-
-def _CheckCodeMirrorChanges(input_api, output_api):
-    errorText = ("ERROR: Attempt to modify CodeMirror. The only allowed changes are "
-                 "rolls from the upstream (http://codemirror.net). If this is a roll, "
-                 "make sure you mention 'roll CodeMirror' (no quotes) in the change description.\n"
-                 "CodeMirror rolling instructions:\n"
-                 "    https://sites.google.com/a/chromium.org/devtools-codemirror-rolling")
-    changeDescription = input_api.change.DescriptionText()
-    errors = []
-    if not "roll codemirror" in changeDescription.lower():
-        errors.append(output_api.PresubmitError(errorText))
-    return errors
+from webkitpy.layout_tests.port import base

[Dirk Pranke, 2014/07/17 00:31:15]

you don't need to import base (see below)

[ivandavid, 2014/07/17 03:04:48]

Done.

+from webkitpy.layout_tests.port import linux
+from webkitpy.layout_tests.port import mac
+from webkitpy.layout_tests.port import win
+from webkitpy.layout_tests.port import browser_test_driver
 
 
-def CheckChangeOnUpload(input_api, output_api):
-    results = []
-    results.extend(_CheckCodeMirrorChanges(input_api, output_api))
-    return results
+def get_port_class_name(port_name):
+    if 'linux' in port_name:
+        return 'BrowserTestLinuxPort'
+    elif 'mac' in port_name:
+        return 'BrowserTestMacPort'
+    elif 'win' in port_name:
+        return 'BrowserTestWinPort'
+    return None
+
+
+class BrowserTestPortOverrides(base.Port):

[Dirk Pranke, 2014/07/17 00:31:15]

this should just be object, not base.Port, since it's a mixin.

[ivandavid, 2014/07/17 03:04:48]

Done.

[ivandavid, 2014/07/17 03:04:48]

I had to swap the order of inheritance, ie.

linux.LinuxPort, BrowserTestPortOverrides -->
BrowserTestOverrides,linux.LinuxPort

because otherwise the overrides would not take effect.

This is because of how super() works correct?

[Dirk Pranke, 2014/07/17 21:20:12]

Correct, the overriding class (the mixin) needs to go first.

+    """Set of overrides that every browser test platform port should have."""
+
+    def _driver_class(self):
+        return browser_test_driver.BrowserTestDriver
+
+    def layout_tests_dir(self):
+        """Overriden function from the base port class. Redirects everything
+        to src/chrome/test/data/printing/layout_tests.
+        """
+        return self.path_from_chromium_base('chrome', 'test', 'data', 'printing', 'layout_tests', 'tests')
+
+
+class BrowserTestLinuxPort(linux.LinuxPort, BrowserTestPortOverrides):
+    pass
+
+
+class BrowserTestMacPort(mac.MacPort, BrowserTestPortOverrides):
+    def _path_to_driver(self, configuration=None):
+        return self._build_path_with_configuration(configuration, self.driver_name())
+
+
+class BrowserTestWinPort(win.WinPort, BrowserTestPortOverrides):
+    pass