Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/script_ref.dart

Issue 378113002: Improve script display in the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library script_ref_element; 5 library script_ref_element;
6 6
7 import 'package:polymer/polymer.dart'; 7 import 'package:polymer/polymer.dart';
8 import 'package:observatory/service.dart'; 8 import 'package:observatory/service.dart';
9 import 'service_ref.dart'; 9 import 'service_ref.dart';
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 } 47 }
48 48
49 String get url { 49 String get url {
50 if (ref == null) { 50 if (ref == null) {
51 return super.url; 51 return super.url;
52 } 52 }
53 if (pos >= 0) { 53 if (pos >= 0) {
54 if (ref.loaded) { 54 if (ref.loaded) {
55 // Script is loaded, get the line number. 55 // Script is loaded, get the line number.
56 Script script = ref; 56 Script script = ref;
57 return '${super.url}#line=${script.tokenToLine(pos)}'; 57 return '${super.url}#pos=${pos}';
58 } else { 58 } else {
59 ref.load().then(_updateProperties); 59 ref.load().then(_updateProperties);
60 } 60 }
61 } 61 }
62 return super.url; 62 return super.url;
63 } 63 }
64 64
65 ScriptRefElement.created() : super.created(); 65 ScriptRefElement.created() : super.created();
66 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698