Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 378093003: Hide the default checkbox on Safe Browsing interstitials (Closed)

Created:
6 years, 5 months ago by felt
Modified:
6 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Hide the default checkbox on Safe Browsing interstitials For some reason, the default checkbox appears underneath the styled checkbox on Mac. This sets the visibility to hidden so that it won't peek out anymore. BUG=386867 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/ssl/interstitial_v2.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
felt
hi dbeam, PTAL.
6 years, 5 months ago (2014-07-09 01:03:59 UTC) #1
Dan Beam
lgtm
6 years, 5 months ago (2014-07-09 02:58:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/378093003/1
6 years, 5 months ago (2014-07-09 02:59:01 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 04:17:32 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 06:15:30 UTC) #5
Message was sent while issue was closed.
Change committed as 281974

Powered by Google App Engine
This is Rietveld 408576698