Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 378063002: Adding cache hit/miss histograms to DiskBasedCertCache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DBCC_MRU_Implement
Patch Set: Fixed wtc nits from previous cl (#361513003) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« net/http/disk_based_cert_cache.cc ('K') | « net/http/disk_based_cert_cache.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e35ae92e0c9f08a2a52273a11e3c56362403f57b..bafb05aa560f4360c6471bea5226ba1341c2d0e6 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3499,6 +3499,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="DiskBasedCertCache.DiskCacheHit" enum="CacheHit">
+ <owner>brandonsalmon@chromium.org</owner>
+ <summary>
+ Whether or not a certificate was found cached on disk by the
+ DiskBasedCertCache.
+ </summary>
+</histogram>
+
+<histogram name="DiskBasedCertCache.MemCacheHit" enum="CacheHit">
jar (doing other things) 2014/07/09 22:22:49 nit: Suggest one histogram, tot replace these two
+ <owner>brandonsalmon@chromium.org</owner>
+ <summary>
+ Whether or not a certificate was found in DiskBasedCertCache's in-memory MRU
+ cache.
+ </summary>
+</histogram>
+
<histogram name="DiskCache.0.FilesAge" units="hours">
<owner>rvargas@chromium.org</owner>
<summary>The age of the cache's files (wall time).</summary>
@@ -35319,6 +35335,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="3" label="HTTP_STREAM_FACTORY_IMPL_JOB_MAIN"/>
</enum>
+<enum name="CacheHit" type="int">
+ <int value="0" label="Miss"/>
+ <int value="1" label="Hit"/>
+</enum>
+
<enum name="CanvasContextType" type="int">
<int value="0" label="2d"/>
<int value="1" label="webkit-3d"/>
« net/http/disk_based_cert_cache.cc ('K') | « net/http/disk_based_cert_cache.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698