net/http/disk_based_cert_cache_unittest.cc - Issue 378063002: Adding cache hit/miss histograms to DiskBasedCertCache.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/http/disk_based_cert_cache_unittest.cc

Issue 378063002: Adding cache hit/miss histograms to DiskBasedCertCache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DBCC_MRU_Implement

Patch Set: Resolved merge conflicts (hopefully). Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/http/disk_based_cert_cache.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/http/disk_based_cert_cache.h"	5 #include "net/http/disk_based_cert_cache.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/callback_helpers.h"	8 #include "base/callback_helpers.h"

9 #include "net/base/completion_callback.h"	9 #include "net/base/completion_callback.h"

10 #include "net/base/io_buffer.h"	10 #include "net/base/io_buffer.h"

11 #include "net/base/net_errors.h"	11 #include "net/base/net_errors.h"

(...skipping 510 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
522	522

523 cache.Get(kCert1.cache_key, get_callback2.callback());	523 cache.Get(kCert1.cache_key, get_callback2.callback());

524 get_callback2.WaitForResult();	524 get_callback2.WaitForResult();

525 EXPECT_TRUE(X509Certificate::IsSameOSCert(get_callback2.cert_handle(),	525 EXPECT_TRUE(X509Certificate::IsSameOSCert(get_callback2.cert_handle(),

526 cert->os_cert_handle()));	526 cert->os_cert_handle()));

527 EXPECT_EQ(1U, cache.mem_cache_hits_for_testing());	527 EXPECT_EQ(1U, cache.mem_cache_hits_for_testing());

528 ASSERT_NO_FATAL_FAILURE(CheckCertCached(&backend, kCert1));	528 ASSERT_NO_FATAL_FAILURE(CheckCertCached(&backend, kCert1));

529 }	529 }

530	530

531 } // namespace net	531 } // namespace net

OLD	NEW