Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4555)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCheckBox.java

Issue 378043002: Visual makeover for infobars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't show buttons with empty text Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCheckBox.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCheckBox.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCheckBox.java
index 1b2ba168aa39b4854afb7da10e6cdeb07bafe437..4cf4f854203de6cdd4242d29005ae4df7aa2d0e5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCheckBox.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCheckBox.java
@@ -6,38 +6,35 @@ package org.chromium.chrome.browser.infobar;
import android.content.Context;
import android.widget.CheckBox;
import android.widget.CompoundButton;
+import android.widget.CompoundButton.OnCheckedChangeListener;
import org.chromium.chrome.R;
/**
* A check box used to determine if a page should always be translated.
*/
-public class TranslateCheckBox {
+public class TranslateCheckBox extends CheckBox implements OnCheckedChangeListener {
private final SubPanelListener mListener;
private final TranslateOptions mOptions;
- public TranslateCheckBox(TranslateOptions options, SubPanelListener listener) {
+ public TranslateCheckBox(Context context, TranslateOptions options, SubPanelListener listener) {
+ super(context);
mOptions = options;
mListener = listener;
+
+ setId(R.id.infobar_extra_check);
+ setText(context.getString(R.string.translate_always_text, mOptions.sourceLanguage()));
+ setChecked(mOptions.alwaysTranslateLanguageState());
+ setOnCheckedChangeListener(this);
}
- public void createContent(Context context, InfoBarLayout layout) {
- CheckBox checkBox = new CheckBox(context);
- checkBox.setId(R.id.infobar_extra_check);
- checkBox.setText(context.getString(R.string.translate_always_text,
- mOptions.sourceLanguage()));
- checkBox.setChecked(mOptions.alwaysTranslateLanguageState());
- checkBox.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
- @Override
- public void onCheckedChanged(CompoundButton view, boolean isChecked) {
- mOptions.toggleAlwaysTranslateLanguageState(isChecked);
- if (isChecked) {
- mListener.onPanelClosed(InfoBar.ACTION_TYPE_NONE);
- } else {
- mListener.onOptionsChanged();
- }
- }
- });
- layout.addGroup(checkBox);
+ @Override
+ public void onCheckedChanged(CompoundButton view, boolean isChecked) {
+ mOptions.toggleAlwaysTranslateLanguageState(isChecked);
+ if (isChecked) {
+ mListener.onPanelClosed(InfoBar.ACTION_TYPE_NONE);
+ } else {
+ mListener.onOptionsChanged();
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698