Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarView.java

Issue 378043002: Visual makeover for infobars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't show buttons with empty text Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarView.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarView.java
index 49d5ebd2fa722cbfbc7b89b4abeb2dcce74b71c1..44d1c760669f0b83b62265affd10c593e1b472ad 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarView.java
@@ -4,52 +4,24 @@
package org.chromium.chrome.browser.infobar;
-import android.content.Context;
/**
* Functions needed to display an InfoBar UI.
*/
public interface InfoBarView {
/**
- * Prepare the InfoBar for display and adding InfoBar-specific controls to the layout.
+ * Prepares the InfoBar for display and adds InfoBar-specific controls to the layout.
* @param layout Layout containing all of the controls.
*/
public void createContent(InfoBarLayout layout);
/**
- * Returns the message indicating what the InfoBar is informing or asking the user about.
- * @param context Context to pull the string from.
- * @return The string to display.
- */
- public CharSequence getMessageText(Context context);
-
- /**
- * Returns text to display on the primary button indicating that some action will be taken.
- * Setting this to null prevents the button from being created.
- * @param context Context to pull the string from.
- * @return The string to display.
- */
- public String getPrimaryButtonText(Context context);
-
- /**
- * Returns text to display on the secondary button, typically indicating that some action will
- * not be taken.
- *
- * Example text includes "Cancel" or "Nope". Setting this to null prevents the button from
- * being created. It is illegal to have a secondary button without a primary button.
- *
- * @param context Context to pull the string from.
- * @return The string to display.
- */
- public String getSecondaryButtonText(Context context);
-
- /**
- * Take some action related to the link being clicked.
+ * Takes some action related to the link being clicked.
*/
public void onLinkClicked();
/**
- * Take some action related to the close button being clicked.
+ * Takes some action related to the close button being clicked.
*/
public void onCloseButtonClicked();

Powered by Google App Engine
This is Rietveld 408576698