chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java - Issue 378043002: Visual makeover for infobars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

Issue 378043002: Visual makeover for infobars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: don't show buttons with empty text Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

index a378301fd4c3b797e3349abde70e892a14a431c1..e991272a282f9702cf6a5dd184f31a1406719f35 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

@@ -369,11 +369,11 @@ public class InfoBarContainer extends LinearLayout {

}

// Called by the tab when it has started loading a new page.

- public void onPageStarted(String url) {

+ public void onPageStarted() {

LinkedList<InfoBar> barsToRemove = new LinkedList<InfoBar>();

for (InfoBar infoBar : mInfoBars) {

- if (infoBar.shouldExpire(url)) {

+ if (infoBar.shouldExpire()) {

barsToRemove.add(infoBar);

}