Move GraphicsTypes* and ColorSpace to Source/platform

Source/platform/graphics/GraphicsTypes.h

Index: Source/platform/graphics/GraphicsTypes.h
diff --git a/Source/core/platform/graphics/GraphicsTypes.h b/Source/platform/graphics/GraphicsTypes.h
similarity index 69%
rename from Source/core/platform/graphics/GraphicsTypes.h
rename to Source/platform/graphics/GraphicsTypes.h
index 5338129e0b791810c876f0526470c60018e4d6a7..a8f6c0d762aae8fc7c3d126b88303bc500265a5c 100644
--- a/Source/core/platform/graphics/GraphicsTypes.h
+++ b/Source/platform/graphics/GraphicsTypes.h
@@ -26,13 +26,15 @@
 #ifndef GraphicsTypes_h
 #define GraphicsTypes_h
 
+#include "platform/PlatformExport.h"
+
 #include "third_party/skia/include/core/SkPaint.h"
 
 #include "wtf/Forward.h"

[abarth-chromium, 2013/10/24 14:13:12]

Please put these headers all together in one block and sort.

[rwlbuis, 2013/10/24 17:04:50]

Done.

 
 namespace WebCore {
 
-enum StrokeStyle {
+enum PLATFORM_EXPORT StrokeStyle {

[abarth-chromium, 2013/10/24 14:13:12]

There's no reason to export enums.  The reason to export something is to make
the symbol available outside the DLL.  There are no symbols associated with
enums.  They're just constants.

[rwlbuis, 2013/10/24 17:04:50]

Done.

     NoStroke,
     SolidStroke,
     DottedStroke,
@@ -41,7 +43,7 @@ enum StrokeStyle {
     WavyStroke,
 };
 
-enum InterpolationQuality {
+enum PLATFORM_EXPORT InterpolationQuality {
     InterpolationDefault,
     InterpolationNone,
     InterpolationLow,
@@ -49,7 +51,7 @@ enum InterpolationQuality {
     InterpolationHigh
 };
 
-enum CompositeOperator {
+enum PLATFORM_EXPORT CompositeOperator {
     CompositeClear,
     CompositeCopy,
     CompositeSourceOver,
@@ -67,7 +69,7 @@ enum CompositeOperator {
 };
 
 // keep it in sync with gMapBlendOpsToXfermodeModes array in SkiaUtils.h
-enum BlendMode {
+enum PLATFORM_EXPORT BlendMode {
     BlendModeNormal,
     BlendModeMultiply,
     BlendModeScreen,
@@ -86,57 +88,57 @@ enum BlendMode {
     BlendModeLuminosity
 };
 
-enum GradientSpreadMethod {
+enum PLATFORM_EXPORT GradientSpreadMethod {
     SpreadMethodPad,
     SpreadMethodReflect,
     SpreadMethodRepeat
 };
 
-enum LineCap {
+enum PLATFORM_EXPORT LineCap {
     ButtCap = SkPaint::kButt_Cap,
     RoundCap = SkPaint::kRound_Cap,
     SquareCap = SkPaint::kSquare_Cap
 };
 
-enum LineJoin {
+enum PLATFORM_EXPORT LineJoin {
     MiterJoin = SkPaint::kMiter_Join,
     RoundJoin = SkPaint::kRound_Join,
     BevelJoin = SkPaint::kBevel_Join
 };
 
-enum HorizontalAlignment { AlignLeft, AlignRight, AlignHCenter };
+enum PLATFORM_EXPORT HorizontalAlignment { AlignLeft, AlignRight, AlignHCenter };
 
-enum TextBaseline { AlphabeticTextBaseline, TopTextBaseline, MiddleTextBaseline, BottomTextBaseline, IdeographicTextBaseline, HangingTextBaseline };
+enum PLATFORM_EXPORT TextBaseline { AlphabeticTextBaseline, TopTextBaseline, MiddleTextBaseline, BottomTextBaseline, IdeographicTextBaseline, HangingTextBaseline };
 
-enum TextAlign { StartTextAlign, EndTextAlign, LeftTextAlign, CenterTextAlign, RightTextAlign };
+enum PLATFORM_EXPORT TextAlign { StartTextAlign, EndTextAlign, LeftTextAlign, CenterTextAlign, RightTextAlign };
 
-enum TextDrawingMode {
+enum PLATFORM_EXPORT TextDrawingMode {
     TextModeFill      = 1 << 0,
     TextModeStroke    = 1 << 1,
 };
 typedef unsigned TextDrawingModeFlags;
 
-enum ColorFilter {
+enum PLATFORM_EXPORT ColorFilter {
     ColorFilterNone,
     ColorFilterLuminanceToAlpha,
     ColorFilterSRGBToLinearRGB,
     ColorFilterLinearRGBToSRGB
 };
 
-String compositeOperatorName(CompositeOperator, BlendMode);
-bool parseCompositeAndBlendOperator(const String&, CompositeOperator&, BlendMode&);
+PLATFORM_EXPORT String compositeOperatorName(CompositeOperator, BlendMode);
+PLATFORM_EXPORT bool parseCompositeAndBlendOperator(const String&, CompositeOperator&, BlendMode&);

[abarth-chromium, 2013/10/24 14:13:12]

These functions do make sense to export because they're symbols that are
implemented in the CPP file.  When someone outside the DLL wants to call these
functions, they need to be able to find the implementation inside the DLL.

[rwlbuis, 2013/10/24 17:04:50]

Done.

 
-String lineCapName(LineCap);
-bool parseLineCap(const String&, LineCap&);
+PLATFORM_EXPORT String lineCapName(LineCap);
+PLATFORM_EXPORT bool parseLineCap(const String&, LineCap&);
 
-String lineJoinName(LineJoin);
-bool parseLineJoin(const String&, LineJoin&);
+PLATFORM_EXPORT String lineJoinName(LineJoin);
+PLATFORM_EXPORT bool parseLineJoin(const String&, LineJoin&);
 
-String textAlignName(TextAlign);
-bool parseTextAlign(const String&, TextAlign&);
+PLATFORM_EXPORT String textAlignName(TextAlign);
+PLATFORM_EXPORT bool parseTextAlign(const String&, TextAlign&);
 
-String textBaselineName(TextBaseline);
-bool parseTextBaseline(const String&, TextBaseline&);
+PLATFORM_EXPORT String textBaselineName(TextBaseline);
+PLATFORM_EXPORT bool parseTextBaseline(const String&, TextBaseline&);
 
 } // namespace WebCore