src/effects/SkEmbossMaskFilter.cpp - Issue 37803002: Adding size parameter to read array functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkEmbossMaskFilter.cpp

Issue 37803002: Adding size parameter to read array functions (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Fixed comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkEmbossMaskFilter.cpp

diff --git a/src/effects/SkEmbossMaskFilter.cpp b/src/effects/SkEmbossMaskFilter.cpp

index 31beb511d5c165a2d66de71ec667796369e2bdde..2d3125000c0f4d4697ade6eaf253e820e7b626cb 100644

--- a/src/effects/SkEmbossMaskFilter.cpp

+++ b/src/effects/SkEmbossMaskFilter.cpp

@@ -132,7 +132,7 @@ bool SkEmbossMaskFilter::filterMask(SkMask* dst, const SkMask& src,

SkEmbossMaskFilter::SkEmbossMaskFilter(SkFlattenableReadBuffer& buffer)

: SkMaskFilter(buffer) {

SkASSERT(buffer.getArrayCount() == sizeof(Light));

- buffer.readByteArray(&fLight);

+ buffer.readByteArray(&fLight, sizeof(Light));

SkASSERT(fLight.fPad == 0); // for the font-cache lookup to be clean

fBlurSigma = buffer.readScalar();

#ifndef DELETE_THIS_CODE_WHEN_SKPS_ARE_REBUILT_AT_V13_AND_ALL_OTHER_INSTANCES_TOO