src/effects/SkBicubicImageFilter.cpp - Issue 37803002: Adding size parameter to read array functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBicubicImageFilter.cpp

Issue 37803002: Adding size parameter to read array functions (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Fixed comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBicubicImageFilter.cpp

diff --git a/src/effects/SkBicubicImageFilter.cpp b/src/effects/SkBicubicImageFilter.cpp

index 778df3fd4f50356759b663fbff03d2177c54c5b4..d6674153d5287d4c3afec471bf413a04ce81a3a5 100644

--- a/src/effects/SkBicubicImageFilter.cpp

+++ b/src/effects/SkBicubicImageFilter.cpp

@@ -41,8 +41,8 @@ SkBicubicImageFilter* SkBicubicImageFilter::CreateMitchell(const SkSize& scale,

}

SkBicubicImageFilter::SkBicubicImageFilter(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) {

- SkDEBUGCODE(uint32_t readSize =) buffer.readScalarArray(fCoefficients);

- SkASSERT(readSize == 16);

+ SkDEBUGCODE(bool success =) buffer.readScalarArray(fCoefficients, 16);

+ SkASSERT(success);

fScale.fWidth = buffer.readScalar();

fScale.fHeight = buffer.readScalar();

buffer.validate(SkScalarIsFinite(fScale.fWidth) &&