src/effects/SkKernel33MaskFilter.cpp - Issue 37803002: Adding size parameter to read array functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkKernel33MaskFilter.cpp

Issue 37803002: Adding size parameter to read array functions (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Cleanup Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkKernel33MaskFilter.cpp

diff --git a/src/effects/SkKernel33MaskFilter.cpp b/src/effects/SkKernel33MaskFilter.cpp

index 485001bbe38fc865899819443c4c419d5e622833..3e99d33e873f35ec75e5f0e5eda8c07d52f6aca5 100644

--- a/src/effects/SkKernel33MaskFilter.cpp

+++ b/src/effects/SkKernel33MaskFilter.cpp

@@ -120,8 +120,9 @@ void SkKernel33MaskFilter::flatten(SkFlattenableWriteBuffer& wb) const {

SkKernel33MaskFilter::SkKernel33MaskFilter(SkFlattenableReadBuffer& rb)

: SkKernel33ProcMaskFilter(rb) {

- SkDEBUGCODE(const uint32_t count = )rb.readIntArray(&fKernel[0][0]);

- SkASSERT(9 == count);

+ size_t size = 9 * sizeof(int32_t);

+ SkDEBUGCODE(bool success = )rb.readIntArray(&fKernel[0][0], size);

+ SkASSERT(success);

fShift = rb.readInt();

}