Adding size parameter to read array functions

src/core/SkColorTable.cpp

Index: src/core/SkColorTable.cpp
diff --git a/src/core/SkColorTable.cpp b/src/core/SkColorTable.cpp
index 242ea6ba64a5c37e1440da31c7fff6a51a3ca42c..adbfc86397c5bb23c8c0e472f7a33ce2d2c01fc8 100644
--- a/src/core/SkColorTable.cpp
+++ b/src/core/SkColorTable.cpp
@@ -92,8 +92,9 @@ SkColorTable::SkColorTable(SkFlattenableReadBuffer& buffer) {
 
     fAlphaType = SkToU8(buffer.readUInt());
     fCount = buffer.getArrayCount();
-    fColors = (SkPMColor*)sk_malloc_throw(fCount * sizeof(SkPMColor));
-    SkDEBUGCODE(const uint32_t countRead =) buffer.readColorArray(fColors);
+    size_t size = fCount * sizeof(SkPMColor);
+    fColors = (SkPMColor*)sk_malloc_throw(size);
+    SkDEBUGCODE(const size_t countRead =) buffer.readColorArray(fColors, size);

[Stephen White, 2013/10/30 20:33:20]

Doesn't this assign a bool to a size_t, since the return value type changed?
Probably should check if it compiles in debug.

In fact, the check below is wrong too, since fCount is in elements, and
countRead (was) in bytes.

[sugoi1, 2013/10/31 14:16:24]

Done.

 #ifdef SK_DEBUG
     SkASSERT((unsigned)fCount <= 256);
     SkASSERT(countRead == fCount);