Issue 378013002: Provide "hostname:port" to the P2P Browser process sockets via P2PHostMsg_CreateSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 378013002: Provide "hostname:port" to the P2P Browser process sockets via P2PHostMsg_CreateSocket. (Closed)

Created:
6 years, 5 months ago by Mallinath (Gone from Chromium)

Modified:
6 years, 5 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, darin-cc_chromium.org, jam, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Provide "hostname:port" to the P2P Browser process sockets via P2PHostMsg_CreateSocket. Currently only hostname is given and it assumes IPEndPoint will have the port number. But the assumption is wrong. TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281932

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	content/browser/renderer_host/p2p/socket_host_tcp.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
	M	content/renderer/p2p/ipc_socket_factory.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Mallinath (Gone from Chromium)

The CQ bit was checked by mallinath@chromium.org

6 years, 5 months ago (2014-07-08 21:14:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/378013002/1

6 years, 5 months ago (2014-07-08 21:19:28 UTC) #3

Message was sent while issue was closed.

Change committed as 281932