OCSPTrySendAndReceive should always set *http_response_data_len, even on...

OCSPTrySendAndReceive should always set *http_response_data_len, even on
failure.  If the response data is larger than the acceptable size, we
should set *http_response_data_len to the actual size because we have
downloaded the entire response.

R=ukai
BUG=18559
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31202

[wtc, 2009-11-06 00:34:50]

I hope it's OK to use goto statements.  I searched for
"goto" in our style guide and didn't find anything.

The output value in *http_response_data_len is documented at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/certhigh...

I quote the relevant text here:

  http_response_data_len is both input and output parameter.
  If a pointer to a PRUint32 is supplied, the http client is
  expected to check the given integer value and always set
  an out value, even on failure.
...
  An out value of "0" means, the failure was unrelated to
  the acceptable size.

  An out value of "1" means, the result data is larger than
  the accpeptable size, but the real size is not yet known
  to the http client implementation and it stopped
  retrieving it,

  Any other out value combined with a return value of
  SECFailure will indicate the actual size of the server
  data.

Since we have downloaded the entire response, we should
not set the out value to 1.

[ukai, 2009-11-06 03:02:01]

LGTM