Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 377993003: Small cleaups to media to support disabling ozone and libvpx properly. (Closed)

Created:
6 years, 5 months ago by awong
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Small cleaups to media to support disabling ozone and libvpx properly. Also combined two identiciation conditional blobs for android into one. With this patch: - ozone files no longer built if use_ozone is 0. - media_unittests builds even if media_use_libvpx is 0. Also removes an unnecessary test_support_perf dependency. Not sure how that ever built since having it means there are 2 main functions (one in test_support_perf and the other in ffmpeg_unittests.cc. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281947

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M media/filters/pipeline_integration_test_base.cc View 1 chunk +2 lines, -0 lines 3 comments Download
M media/media.gyp View 3 chunks +5 lines, -5 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
scherkus (not reviewing)
two q's https://codereview.chromium.org/377993003/diff/1/media/filters/pipeline_integration_test_base.cc File media/filters/pipeline_integration_test_base.cc (right): https://codereview.chromium.org/377993003/diff/1/media/filters/pipeline_integration_test_base.cc#newcode252 media/filters/pipeline_integration_test_base.cc:252: #endif // !defined(MEDIA_DISABLE_LIBVPX) is this only to ...
6 years, 5 months ago (2014-07-08 21:10:03 UTC) #1
awong
https://codereview.chromium.org/377993003/diff/1/media/filters/pipeline_integration_test_base.cc File media/filters/pipeline_integration_test_base.cc (right): https://codereview.chromium.org/377993003/diff/1/media/filters/pipeline_integration_test_base.cc#newcode252 media/filters/pipeline_integration_test_base.cc:252: #endif // !defined(MEDIA_DISABLE_LIBVPX) On 2014/07/08 21:10:02, scherkus wrote: > ...
6 years, 5 months ago (2014-07-08 21:28:03 UTC) #2
scherkus (not reviewing)
lgtm https://codereview.chromium.org/377993003/diff/1/media/filters/pipeline_integration_test_base.cc File media/filters/pipeline_integration_test_base.cc (right): https://codereview.chromium.org/377993003/diff/1/media/filters/pipeline_integration_test_base.cc#newcode252 media/filters/pipeline_integration_test_base.cc:252: #endif // !defined(MEDIA_DISABLE_LIBVPX) On 2014/07/08 21:28:03, awong wrote: ...
6 years, 5 months ago (2014-07-08 21:30:01 UTC) #3
awong
The CQ bit was checked by ajwong@chromium.org
6 years, 5 months ago (2014-07-08 22:25:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/377993003/1
6 years, 5 months ago (2014-07-08 22:27:11 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 05:14:02 UTC) #6
Message was sent while issue was closed.
Change committed as 281947

Powered by Google App Engine
This is Rietveld 408576698