update our build system to support the experimental L-Release NDK

update our build system to support the experimental L-Release NDK

This includes adding 64-bit support for arm, x86, and mips.

R=borenet@google.com

Committed: https://skia.googlesource.com/skia/+/c7d29c8

[borenet, 2014-07-08 20:04:12]

LGTM with a couple of questions.

https://codereview.chromium.org/377993002/diff/1/gyp/gpu.gyp
File gyp/gpu.gyp (right):

https://codereview.chromium.org/377993002/diff/1/gyp/gpu.gyp#newcode219
gyp/gpu.gyp:219: 'GR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE=1',
Is there a source change to go along with this?

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_setup.sh:141: DEFINES="${DEFINES}
skia_arch_type=arm64 skia_arch_width=64"
Any reason not to do:
"skia_arch_type=arm skia_arch_width=64"
?

That's more in line with arch_type=x86 arch_width=64

[djsollen, 2014-07-08 20:14:46]

https://codereview.chromium.org/377993002/diff/1/gyp/gpu.gyp
File gyp/gpu.gyp (right):

https://codereview.chromium.org/377993002/diff/1/gyp/gpu.gyp#newcode219
gyp/gpu.gyp:219: 'GR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE=1',
On 2014/07/08 20:04:12, borenet wrote:
> Is there a source change to go along with this?

Nope. The new NDK toolchain has updated header files that use this new
signature.

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_setup.sh:141: DEFINES="${DEFINES}
skia_arch_type=arm64 skia_arch_width=64"
On 2014/07/08 20:04:12, borenet wrote:
> Any reason not to do:
> "skia_arch_type=arm skia_arch_width=64"
> ?
> 
> That's more in line with arch_type=x86 arch_width=64

we can, but we already have gyp conditions that use arm64 and I didn't want to
have to refactor that as part of this CL.

[mtklein, 2014-07-08 20:16:53]

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_setup.sh:121: DEFINES="${DEFINES}
skia_resource_cache_mb_limit=32"
No need to cap any of these before trying the default?  We only do this for
resource-limited devices today.

[djsollen, 2014-07-08 20:39:05]

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_setup.sh:121: DEFINES="${DEFINES}
skia_resource_cache_mb_limit=32"
On 2014/07/08 20:16:53, mtklein wrote:
> No need to cap any of these before trying the default?  We only do this for
> resource-limited devices today.

Done.

[qiankun, 2014-07-10 05:24:15]

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/u...
File platform_tools/android/bin/utils/setup_toolchain.sh (right):

https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/u...
platform_tools/android/bin/utils/setup_toolchain.sh:34: API_LEVEL=L #
Experimental Android L-Release system images
I tried this NDK. Got error when running bench:
ERROR: Unable to open the shared library.
ERROR: dlopen failed: cannot locate symbol "glMapBufferRangeEXT" referenced by
"/data/local/tmp/libskia_android.so"...EXIT_CODE is 255

[djsollen, 2014-07-10 11:57:10]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-07-10 11:57:56]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/djsollen@google.com/377993002/1

[djsollen, 2014-07-10 12:00:04]

On 2014/07/10 05:24:15, qiankun wrote:
>
https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/u...
> File platform_tools/android/bin/utils/setup_toolchain.sh (right):
> 
>
https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/u...
> platform_tools/android/bin/utils/setup_toolchain.sh:34: API_LEVEL=L #
> Experimental Android L-Release system images
> I tried this NDK. Got error when running bench:
> ERROR: Unable to open the shared library.
> ERROR: dlopen failed: cannot locate symbol "glMapBufferRangeEXT" referenced by
> "/data/local/tmp/libskia_android.so"...EXIT_CODE is 255

Still landing this to get all the 32-bit bots updated.  The next step is to add
64-bit bots and in order to do that I'll need to fix this and potentially other
issues.

[djsollen, 2014-07-10 12:10:26]

Committed patchset #2 manually as rc7d29c8 (presubmit successful).

[djsollen, 2014-07-10 14:06:43]

On 2014/07/10 05:24:15, qiankun wrote:
>
https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/u...
> File platform_tools/android/bin/utils/setup_toolchain.sh (right):
> 
>
https://codereview.chromium.org/377993002/diff/1/platform_tools/android/bin/u...
> platform_tools/android/bin/utils/setup_toolchain.sh:34: API_LEVEL=L #
> Experimental Android L-Release system images
> I tried this NDK. Got error when running bench:
> ERROR: Unable to open the shared library.
> ERROR: dlopen failed: cannot locate symbol "glMapBufferRangeEXT" referenced by
> "/data/local/tmp/libskia_android.so"...EXIT_CODE is 255

what device are you running on and what version is that device?  Unless your
running on a device using the L-release preview that is expected.