ozone: test: Convert to PlatformWindow

ozone: test: Convert to PlatformWindow

A test window is just a path to write an image file to. Each window has
a unique image path.

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran test platform
NOTRY=true

depends on https://codereview.chromium.org/375053002/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283875

[alexst (slow to review), 2014-07-17 15:28:30]

lgtm with nits.

https://codereview.chromium.org/377973005/diff/20001/ui/ozone/platform/test/t...
File ui/ozone/platform/test/test_window_manager.cc (right):

https://codereview.chromium.org/377973005/diff/20001/ui/ozone/platform/test/t...
ui/ozone/platform/test/test_window_manager.cc:68: if
(!DirectoryExists(location_) && !base::CreateDirectory(location_) &&
Can you move this into a separate function? Maybe InitializeHardware() since
it's already there and you can handle errors more appropriately?

I prefer not to have anything but trivial assignments in the ctor because it has
a tendency to cause bizarre issues if something goes wrong.

https://codereview.chromium.org/377973005/diff/20001/ui/ozone/platform/test/t...
ui/ozone/platform/test/test_window_manager.cc:105: TestWindow* window =
windows_.Lookup(widget);
Please DCHECK that this is sane.

[spang, 2014-07-17 19:51:44]

https://codereview.chromium.org/377973005/diff/20001/ui/ozone/platform/test/t...
File ui/ozone/platform/test/test_window_manager.cc (right):

https://codereview.chromium.org/377973005/diff/20001/ui/ozone/platform/test/t...
ui/ozone/platform/test/test_window_manager.cc:68: if
(!DirectoryExists(location_) && !base::CreateDirectory(location_) &&
On 2014/07/17 15:28:30, alexst wrote:
> Can you move this into a separate function? Maybe InitializeHardware() since
> it's already there and you can handle errors more appropriately?
> 
> I prefer not to have anything but trivial assignments in the ctor because it
has
> a tendency to cause bizarre issues if something goes wrong.

Done.

https://codereview.chromium.org/377973005/diff/20001/ui/ozone/platform/test/t...
ui/ozone/platform/test/test_window_manager.cc:105: TestWindow* window =
windows_.Lookup(widget);
On 2014/07/17 15:28:30, alexst wrote:
> Please DCHECK that this is sane.

Done.

[spang, 2014-07-17 21:08:56]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-07-17 21:10:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/377973005/60001

[commit-bot: I haz the power, 2014-07-17 21:13:37]

Change committed as 283875