Issue 377903002: Revert of Separate client and server pushed streams limits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377903002: Revert of Separate client and server pushed streams limits. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach

Modified:
6 years, 5 months ago

Reviewers:
baranovich, Johnny

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Separate client and server pushed streams limits. (https://codereview.chromium.org/367963003/) Reason for revert: [Sheriff] This breaks asan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/3768 http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%282%29/builds/3271 Original issue's description: > Separate client and server pushed streams limits. > Reject push streams which exceed the limit. > > For now, the browser will send RST_STREAM with REFUSED_STREAM status. > This mimics mod_spdy behavior. > > BUG=170544, 377538 > > R=jgraettinger@chromium.org > > TEST=SpdySessionTest.PushedStreamShouldNotCountToClientConcurrencyLimit > SpdySessionTest.RejectPushedStreamExceedingConcurrencyLimit > SpdySessionTest.IgnoreReservedRemoteStreamsCount > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281698 TBR=jgraettinger@chromium.org,baranovich@yandex-team.ru NOTREECHECKS=true NOTRY=true BUG=170544, 377538 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281705

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -304 lines)			Patch
M	net/spdy/spdy_session.h	View	5 chunks	+1 line, -24 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View	7 chunks	+2 lines, -28 lines	0 comments	Download
M	net/spdy/spdy_session_unittest.cc	View	1 chunk	+0 lines, -252 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Created Revert of Separate client and server pushed streams limits.

6 years, 5 months ago (2014-07-08 10:13:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/377903002/1

6 years, 5 months ago (2014-07-08 10:13:38 UTC) #2

Message was sent while issue was closed.

Change committed as 281705