Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: tools/gypv8sh.py

Issue 377893002: Add more debugging output to gypv8sh (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gypv8sh.py
diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py
index 8245f5b276ccce7a8746e592f48602a17c227e63..0c3d096368de38c92ae5ea053d7eaf7f21f3a6fd 100755
--- a/tools/gypv8sh.py
+++ b/tools/gypv8sh.py
@@ -48,6 +48,13 @@ def main ():
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, bufsize=0)
out, err = p.communicate()
if p.returncode:
+ # TODO(jochen): Remove once crbug.com/370551 is resolved.
+ if sys.platform == 'darwin':
+ cmd[:0] = [
+ 'gdb', '-batch', '-ex', 'run', '-ex' 'bt', '-ex', 'quit', '-args']
+ p = subprocess.Popen(
+ cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, bufsize=0)
+ out, err = p.communicate()
raise Exception('Failed to run d8', out, err)
with open(cxxoutfile, 'wb') as f:
f.write(out)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698