Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 377873002: ServiceWorker: Clean up Service Worker codebase in renderer (Closed)

Created:
6 years, 5 months ago by nhiroki
Modified:
6 years, 5 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Clean up Service Worker codebase in renderer BUG=n/a TEST=cpplint Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M content/renderer/service_worker/embedded_worker_context_client.h View 3 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_message_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nhiroki
PTAL, thanks!
6 years, 5 months ago (2014-07-08 09:09:12 UTC) #1
horo
lgtm
6 years, 5 months ago (2014-07-08 09:15:14 UTC) #2
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 5 months ago (2014-07-08 09:19:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/377873002/1
6 years, 5 months ago (2014-07-08 09:20:48 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 11:24:52 UTC) #5
Message was sent while issue was closed.
Change committed as 281719

Powered by Google App Engine
This is Rietveld 408576698