Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: include/core/SkPicture.h

Issue 377833007: Harden SkPicture interface a bit (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPicture.h
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h
index 6c486c978900683ab35b1adeaafc253864b30374..8e54b1d6eb815155323a0b7ac935035accad4cdd 100644
--- a/include/core/SkPicture.h
+++ b/include/core/SkPicture.h
@@ -200,7 +200,7 @@ public:
bool suitableForGpuRasterization(GrContext*, const char ** = NULL) const;
#endif
-protected:
+private:
// V2 : adds SkPixelRef's generation ID.
// V3 : PictInfo tag at beginning, and EOF tag at the end
// V4 : move SkPictInfo to be the header
@@ -241,8 +241,7 @@ protected:
mutable uint32_t fUniqueID;
- // TODO: make fData and fWidth/fHeight private
- SkAutoTDelete<SkPictureData> fData;
+ SkAutoTDelete<const SkPictureData> fData;
int fWidth, fHeight;
mutable SkAutoTUnref<const AccelData> fAccelData;
@@ -254,7 +253,6 @@ protected:
SkPicture(int width, int height, const SkPictureRecord& record, bool deepCopyOps);
-private:
static void WriteTagSize(SkWriteBuffer& buffer, uint32_t tag, size_t size);
static void WriteTagSize(SkWStream* stream, uint32_t tag, size_t size);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698