Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 377833007: Harden SkPicture interface a bit (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Harden SkPicture interface a bit With the removal of SkTimedPicture we can now make more of SkPicture private. Committed: https://skia.googlesource.com/skia/+/6daadc7481b11655c77569eb0720fe037027cb30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M include/core/SkPicture.h View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-08 15:05:56 UTC) #1
reed1
always a fan of private: lgtm
6 years, 5 months ago (2014-07-08 15:16:11 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-08 15:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/377833007/1
6 years, 5 months ago (2014-07-08 15:21:56 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 15:38:23 UTC) #5
Message was sent while issue was closed.
Change committed as 6daadc7481b11655c77569eb0720fe037027cb30

Powered by Google App Engine
This is Rietveld 408576698