Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 377833003: Fix for-loop with const/let and empty condition/iteration statements. (Closed)

Created:
6 years, 5 months ago by ulan
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix for-loop with const/let and empty condition/iteration statements. BUG=v8:3425, v8:3424 LOG=N TEST=mjsunit/harmony/empty-for.js R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -29 lines) Patch
M src/parser.cc View 3 chunks +25 lines, -5 lines 0 comments Download
A + test/mjsunit/harmony/empty-for.js View 1 chunk +42 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 5 months ago (2014-07-08 08:24:31 UTC) #1
rossberg
lgtm
6 years, 5 months ago (2014-07-08 09:04:41 UTC) #2
ulan
6 years, 5 months ago (2014-07-09 07:50:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698