Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: skia/BUILD.gn

Issue 377833002: GN: Fix skia build on mac, use -msse4.1 everywhere (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use -msse4.1 take two Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/skia_library_opts.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 8a7ff6ac16195ae944f379198c5f5605e8b98811..b9a0106499db4e1c1294778508704ea6e7c44453 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -136,6 +136,10 @@ config("skia_config") {
"USE_CHROMIUM_SKIA",
]
}
+
+ if (is_mac) {
+ defines += [ "SK_BUILD_FOR_MAC" ]
+ }
}
# Internal-facing config for Skia library code.
@@ -556,7 +560,7 @@ source_set("skia_opts") {
}
if (is_linux || is_mac) {
- cflags += [ "-msse4" ]
+ cflags += [ "-msse4.1" ]
}
} else if (cpu_arch == "arm") {
sources = [
« no previous file with comments | « no previous file | skia/skia_library_opts.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698