media/base/audio_video_metadata_extractor.cc - Issue 377803004: Fixes for re-enabling more MSVC level 4 warnings: media/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_video_metadata_extractor.cc

Issue 377803004: Fixes for re-enabling more MSVC level 4 warnings: media/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/audio_video_metadata_extractor.cc

diff --git a/media/base/audio_video_metadata_extractor.cc b/media/base/audio_video_metadata_extractor.cc

index 7a8cf766abde16b92d10c4f03647682eaf02a40d..fd666f6c919448ccd386a91e702fa1d9fc5ba101 100644

--- a/media/base/audio_video_metadata_extractor.cc

+++ b/media/base/audio_video_metadata_extractor.cc

@@ -236,8 +236,9 @@ void AudioVideoMetadataExtractor::ExtractDictionary(

if (!metadata)

return;

- AVDictionaryEntry* tag = NULL;

- while ((tag = av_dict_get(metadata, "", tag, AV_DICT_IGNORE_SUFFIX))) {

+ for (AVDictionaryEntry* tag =

+ av_dict_get(metadata, "", NULL, AV_DICT_IGNORE_SUFFIX);

+ tag; tag = av_dict_get(metadata, "", tag, AV_DICT_IGNORE_SUFFIX)) {

if (raw_tags->find(tag->key) == raw_tags->end())

(*raw_tags)[tag->key] = tag->value;