Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 377783005: Remove unused code in common/renderer about autocomplete_match_type (Closed)

Created:
6 years, 5 months ago by Jun Mukai
Modified:
6 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered, hashimoto, blundell
Project:
chromium
Visibility:
Public.

Description

Remove unused code in common/renderer about autocomplete_match_type autocomplete_match_type is in chrome/common, but it is not used by common and renderer actually. This CL removes the unused includes and unused class referring AutocompleteMatchType. BUG=388510 R=pkasting@chromium.org, brettw@chromium.org TBR=jered@chromium.org, jschuh@chromium.org TEST=build all Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M chrome/common/instant_types.h View 2 chunks +0 lines, -40 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Jun Mukai
6 years, 5 months ago (2014-07-08 01:46:31 UTC) #1
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-08 01:47:54 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-08 01:51:31 UTC) #3
Jun Mukai
The CQ bit was unchecked by mukai@chromium.org
6 years, 5 months ago (2014-07-08 01:51:34 UTC) #4
Jun Mukai
+brettw, could you review instant_types.h? It's a significant removal.
6 years, 5 months ago (2014-07-08 01:54:15 UTC) #5
brettw
LGTM, but can you clarify the commit message? It talks about a dependency (but I ...
6 years, 5 months ago (2014-07-08 22:01:55 UTC) #6
Jun Mukai
On 2014/07/08 22:01:55, brettw wrote: > LGTM, but can you clarify the commit message? > ...
6 years, 5 months ago (2014-07-08 22:16:04 UTC) #7
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-08 22:16:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/377783005/1
6 years, 5 months ago (2014-07-08 22:17:48 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 01:55:30 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 01:59:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/78713)
6 years, 5 months ago (2014-07-09 01:59:34 UTC) #12
Jun Mukai
On 2014/07/09 01:59:34, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-09 07:19:25 UTC) #13
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-09 07:19:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/377783005/1
6 years, 5 months ago (2014-07-09 07:20:10 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 07:28:03 UTC) #16
Message was sent while issue was closed.
Change committed as 281984

Powered by Google App Engine
This is Rietveld 408576698