extensions/common/features/manifest_feature.cc - Issue 377753003: Remove GetContexts() from the public interface of extensions::Feature. It was

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/manifest_feature.cc

Issue 377753003: Remove GetContexts() from the public interface of extensions::Feature. It was (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/features/complex_feature.cc ('K') | « extensions/common/features/feature.h ('k') | extensions/common/features/permission_feature.cc » ('j') | extensions/common/features/simple_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/features/manifest_feature.cc

diff --git a/extensions/common/features/manifest_feature.cc b/extensions/common/features/manifest_feature.cc

index 0a4ad9bb530ccfa8fe5db75cdd56706aa933809d..f169c6a8ac8451a54c7ec378d5db4c19938fbb19 100644

--- a/extensions/common/features/manifest_feature.cc

+++ b/extensions/common/features/manifest_feature.cc

@@ -44,7 +44,7 @@ std::string ManifestFeature::Parse(const base::DictionaryValue* value) {

"value for extension_types.";

}

- if (!GetContexts()->empty())

+ if (value->HasKey("contexts"))

return name() + ": Manifest features do not support contexts.";

return std::string();