Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Side by Side Diff: extensions/common/features/feature.h

Issue 377753003: Remove GetContexts() from the public interface of extensions::Feature. It was (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_FEATURES_FEATURE_H_ 5 #ifndef EXTENSIONS_COMMON_FEATURES_FEATURE_H_
6 #define EXTENSIONS_COMMON_FEATURES_FEATURE_H_ 6 #define EXTENSIONS_COMMON_FEATURES_FEATURE_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 static Availability CreateAvailability(AvailabilityResult result, 101 static Availability CreateAvailability(AvailabilityResult result,
102 const std::string& message); 102 const std::string& message);
103 103
104 const std::string& name() const { return name_; } 104 const std::string& name() const { return name_; }
105 void set_name(const std::string& name) { name_ = name; } 105 void set_name(const std::string& name) { name_ = name; }
106 bool no_parent() const { return no_parent_; } 106 bool no_parent() const { return no_parent_; }
107 107
108 // Gets the platform the code is currently running on. 108 // Gets the platform the code is currently running on.
109 static Platform GetCurrentPlatform(); 109 static Platform GetCurrentPlatform();
110 110
111 virtual std::set<Context>* GetContexts() = 0;
112
113 // Tests whether this is an internal API or not. 111 // Tests whether this is an internal API or not.
114 virtual bool IsInternal() const = 0; 112 virtual bool IsInternal() const = 0;
115 113
116 // Returns True for features excluded from service worker backed contexts. 114 // Returns True for features excluded from service worker backed contexts.
117 virtual bool IsBlockedInServiceWorker() const = 0; 115 virtual bool IsBlockedInServiceWorker() const = 0;
118 116
119 // Returns true if the feature is available to be parsed into a new extension 117 // Returns true if the feature is available to be parsed into a new extension
120 // manifest. 118 // manifest.
121 Availability IsAvailableToManifest(const std::string& extension_id, 119 Availability IsAvailableToManifest(const std::string& extension_id,
122 Manifest::Type type, 120 Manifest::Type type,
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 virtual bool IsIdInWhitelist(const std::string& extension_id) const = 0; 153 virtual bool IsIdInWhitelist(const std::string& extension_id) const = 0;
156 154
157 protected: 155 protected:
158 std::string name_; 156 std::string name_;
159 bool no_parent_; 157 bool no_parent_;
160 }; 158 };
161 159
162 } // namespace extensions 160 } // namespace extensions
163 161
164 #endif // EXTENSIONS_COMMON_FEATURES_FEATURE_H_ 162 #endif // EXTENSIONS_COMMON_FEATURES_FEATURE_H_
OLDNEW
« no previous file with comments | « extensions/common/features/complex_feature.cc ('k') | extensions/common/features/manifest_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698