[Ozone-GBM] Add basic support for display configuration over IPC

[Ozone-GBM] Add basic support for display configuration over IPC

BUG=377497
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282036

[dnicoara, 2014-07-08 13:58:45]

PTAL

The related IPC CL is at https://codereview.chromium.org/378673002/

It's not pretty but it gets the job done. I'll look into morphing the display
configuration path to be asynchronous in order to have a sane initialization
process, but until then, this is better than nothing.

[spang, 2014-07-08 14:40:53]

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
File ui/ozone/platform/dri/gpu_platform_support_gbm.cc (left):

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
ui/ozone/platform/dri/gpu_platform_support_gbm.cc:29: 
maybe instead of all these ifdefs, chain another chromeos-specific object on &
do

#if defined(OS_CHROMEOS)
if (!handled)
  handled = display_message_handler_->OnMessageReceived(message);
#endif

You could even add a generic way to add more handlers, but that might be
overkill.

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
File ui/ozone/platform/dri/gpu_platform_support_gbm.cc (right):

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
ui/ozone/platform/dri/gpu_platform_support_gbm.cc:63: ndd_.reset(ndd.release());
ndd_ = ndd.Pass();

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
File ui/ozone/platform/dri/gpu_platform_support_host_gbm.cc (right):

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
ui/ozone/platform/dri/gpu_platform_support_host_gbm.cc:55: 
same here.. could do

if (!handled)
  handled = display_message_handler_->OnMessageReceived(message);

and move all the display functions to NativeDisplayDelegateProxy.

[dnicoara, 2014-07-08 17:13:35]

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
File ui/ozone/platform/dri/gpu_platform_support_gbm.cc (left):

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
ui/ozone/platform/dri/gpu_platform_support_gbm.cc:29: 
On 2014/07/08 14:40:52, spang wrote:
> maybe instead of all these ifdefs, chain another chromeos-specific object on &
> do
> 
> #if defined(OS_CHROMEOS)
> if (!handled)
>   handled = display_message_handler_->OnMessageReceived(message);
> #endif
> 
> You could even add a generic way to add more handlers, but that might be
> overkill.

Done.

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
File ui/ozone/platform/dri/gpu_platform_support_host_gbm.cc (right):

https://codereview.chromium.org/377753002/diff/20001/ui/ozone/platform/dri/gp...
ui/ozone/platform/dri/gpu_platform_support_host_gbm.cc:55: 
On 2014/07/08 14:40:53, spang wrote:
> same here.. could do
> 
> if (!handled)
>   handled = display_message_handler_->OnMessageReceived(message);
> 
> and move all the display functions to NativeDisplayDelegateProxy.

Done.

[spang, 2014-07-08 17:26:21]

lgtm

https://codereview.chromium.org/377753002/diff/80001/ui/ozone/platform/dri/ch...
File ui/ozone/platform/dri/chromeos/display_message_handler.h (right):

https://codereview.chromium.org/377753002/diff/80001/ui/ozone/platform/dri/ch...
ui/ozone/platform/dri/chromeos/display_message_handler.h:22: class
DisplayMessageHandler : public GpuPlatformSupport {
I'm not super happy about reusing the main interface.. but I guess this works.

[dnicoara, 2014-07-09 14:38:41]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:39:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dnicoara@chromium.org/377753002/80001

[commit-bot: I haz the power, 2014-07-09 14:42:08]

Change committed as 282036

[Justin Novosad, 2014-07-09 15:36:06]

On 2014/07/09 14:42:08, I haz the power (commit-bot) wrote:
> Change committed as 282036

Could this be causing the following failure?
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20(reti...

meter-style test failing on retina display

[dnicoara, 2014-07-09 15:50:58]

Can't be since Ozone changes aren't compiled on Mac.


On Wed, Jul 9, 2014 at 11:36 AM, <junov@chromium.org> wrote:

> On 2014/07/09 14:42:08, I haz the power (commit-bot) wrote:
>
>> Change committed as 282036
>>
>
> Could this be causing the following failure?
> http://build.chromium.org/p/chromium.webkit/builders/
> WebKit%20Mac10.8%20(retina)/builds/15940
>
> meter-style test failing on retina display
>
> https://codereview.chromium.org/377753002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.