Issue 377733002: Handle close button in SkOSWindow_Unix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377733002: Handle close button in SkOSWindow_Unix. (Closed)

Created:
6 years, 5 months ago by bungeman-skia

Modified:
6 years, 5 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Handle close button in SkOSWindow_Unix. Currently X with most Window managers calls 'exit' when the close button is used. This can cause issues as the Window is not properly destroyed. With this change we can handle this window message and properly exit. Committed: https://skia.googlesource.com/skia/+/6f157d914e3bf1af677615660ac837a98060a8ac

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	src/views/unix/SkOSWindow_Unix.cpp	View		3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/377733002/1

6 years, 5 months ago (2014-07-07 21:59:26 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia ...

6 years, 5 months ago (2014-07-07 22:20:45 UTC) #5

commit-bot: I haz the power

6 years, 5 months ago (2014-07-07 22:46:02 UTC) #6

Message was sent while issue was closed.

Change committed as 6f157d914e3bf1af677615660ac837a98060a8ac

Expand Messages | Collapse Messages