Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3365)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.h

Issue 377723003: Remove some unnecessary heap allocations and copies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: devtools only Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.h
diff --git a/chrome/browser/devtools/devtools_ui_bindings.h b/chrome/browser/devtools/devtools_ui_bindings.h
index 94bf7ba794e870b8f1d1bb0b056fb71009280aa8..7cc2f37f3f412d406079a9ac9965c38f0128390f 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.h
+++ b/chrome/browser/devtools/devtools_ui_bindings.h
@@ -73,8 +73,6 @@ class DevToolsUIBindings : public content::NotificationObserver,
const base::Value* arg1,
const base::Value* arg2,
const base::Value* arg3);
- void DispatchEventOnFrontend(const std::string& event_type,
- const base::Value* event_data);
private:
// content::NotificationObserver:
virtual void Observe(int type,
@@ -128,7 +126,7 @@ class DevToolsUIBindings : public content::NotificationObserver,
// Forwards discovered devices to frontend.
virtual void PopulateRemoteDevices(const std::string& source,
- scoped_ptr<base::ListValue> targets);
+ const base::ListValue& targets);
void DocumentOnLoadCompletedInMainFrame();
@@ -157,6 +155,9 @@ class DevToolsUIBindings : public content::NotificationObserver,
void UpdateTheme();
void AddDevToolsExtensionsToClient();
+ void DispatchEventOnFrontend(const std::string& event_type,
+ const base::Value& event_data);
+
class FrontendWebContentsObserver;
friend class FrontendWebContentsObserver;
scoped_ptr<FrontendWebContentsObserver> frontend_contents_observer_;
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698