Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 377723003: Remove some unnecessary heap allocations and copies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: devtools only Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | chrome/browser/ui/webui/inspect_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index ae45cdbd45306b20c654adb1e1dbb58c90cc0f8e..1517d2147d0737306c852070e451b93b9eef51bb 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -387,10 +387,10 @@ void DevToolsUIBindings::DispatchOnEmbedder(const std::string& message) {
std::string error;
embedder_message_dispatcher_->Dispatch(method, params, &error);
if (id) {
- scoped_ptr<base::Value> id_value(base::Value::CreateIntegerValue(id));
- scoped_ptr<base::Value> error_value(base::Value::CreateStringValue(error));
+ base::FundamentalValue id_value(id);
+ base::StringValue error_value(error);
CallClientFunction("InspectorFrontendAPI.embedderMessageAck",
- id_value.get(), error_value.get(), NULL);
+ &id_value, &error_value, NULL);
}
}
@@ -623,14 +623,13 @@ void DevToolsUIBindings::EnableRemoteDeviceCounter(bool enable) {
}
void DevToolsUIBindings::DeviceCountChanged(int count) {
- base::FundamentalValue value(count);
- DispatchEventOnFrontend(kDeviceCountChanged, &value);
+ DispatchEventOnFrontend(kDeviceCountChanged, base::FundamentalValue(count));
}
void DevToolsUIBindings::PopulateRemoteDevices(
const std::string& source,
- scoped_ptr<base::ListValue> targets) {
- DispatchEventOnFrontend(kDevicesChanged, targets.get());
+ const base::ListValue& targets) {
+ DispatchEventOnFrontend(kDevicesChanged, targets);
}
void DevToolsUIBindings::FileSavedAs(const std::string& url) {
@@ -796,13 +795,13 @@ void DevToolsUIBindings::CallClientFunction(const std::string& function_name,
void DevToolsUIBindings::DispatchEventOnFrontend(
const std::string& event_type,
- const base::Value* event_data) {
+ const base::Value& event_data) {
if (subscribers_.find(event_type) == subscribers_.end())
return;
- base::StringValue event_type_value = base::StringValue(event_type);
+ base::StringValue event_type_value(event_type);
CallClientFunction("InspectorFrontendAPI.dispatchEventToListeners",
&event_type_value,
- event_data,
+ &event_data,
NULL);
}
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | chrome/browser/ui/webui/inspect_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698