content/common/child_process_host_impl.cc - Issue 377723002: Fixes for re-enabling more MSVC level 4 warnings: content/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/child_process_host_impl.cc

Issue 377723002: Fixes for re-enabling more MSVC level 4 warnings: content/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/child_process_host_impl.cc

diff --git a/content/common/child_process_host_impl.cc b/content/common/child_process_host_impl.cc

index 1dccab0838504ffffcf51186cfaf5d23b451b06d..6fa01994a14182149fc320a2c5aa694a48648171 100644

--- a/content/common/child_process_host_impl.cc

+++ b/content/common/child_process_host_impl.cc

@@ -271,9 +271,9 @@ bool ChildProcessHostImpl::OnMessageReceived(const IPC::Message& msg) {

void ChildProcessHostImpl::OnChannelConnected(int32 peer_pid) {

if (!peer_handle_ &&

- !base::OpenPrivilegedProcessHandle(peer_pid, &peer_handle_) &&

- !(peer_handle_ = delegate_->GetHandle())) {

- NOTREACHED();

+ !base::OpenPrivilegedProcessHandle(peer_pid, &peer_handle_)) {

+ peer_handle_ = delegate_->GetHandle();

+ DCHECK(peer_handle_);

}

opening_channel_ = false;

delegate_->OnChannelConnected(peer_pid);