Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 377713003: [Suggestions] Remove dependence on InstantIOContext (Closed)

Created:
6 years, 5 months ago by Mathieu
Modified:
6 years, 5 months ago
Reviewers:
huangs
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Remove dependence on InstantIOContext It was unnecessary for a debug page. BUG=387751 R=huangs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281731

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome/browser/search/suggestions/suggestions_source.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_source.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mathieu
Hi Sam, can you have a look?
6 years, 5 months ago (2014-07-07 21:26:15 UTC) #1
huangs
LGTM with small suggestion. https://codereview.chromium.org/377713003/diff/1/chrome/browser/search/suggestions/suggestions_source.cc File chrome/browser/search/suggestions/suggestions_source.cc (right): https://codereview.chromium.org/377713003/diff/1/chrome/browser/search/suggestions/suggestions_source.cc#newcode21 chrome/browser/search/suggestions/suggestions_source.cc:21: #include "net/url_request/url_request.h" Remove #include "net/url_request/url_request.h" ...
6 years, 5 months ago (2014-07-07 21:38:47 UTC) #2
Mathieu
Done, submitting! https://codereview.chromium.org/377713003/diff/1/chrome/browser/search/suggestions/suggestions_source.cc File chrome/browser/search/suggestions/suggestions_source.cc (right): https://codereview.chromium.org/377713003/diff/1/chrome/browser/search/suggestions/suggestions_source.cc#newcode21 chrome/browser/search/suggestions/suggestions_source.cc:21: #include "net/url_request/url_request.h" On 2014/07/07 21:38:47, huangs1 wrote: ...
6 years, 5 months ago (2014-07-08 00:15:12 UTC) #3
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-08 00:15:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/377713003/20001
6 years, 5 months ago (2014-07-08 00:16:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 04:16:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 04:42:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90553)
6 years, 5 months ago (2014-07-08 04:42:31 UTC) #8
Mathieu
6 years, 5 months ago (2014-07-08 13:08:03 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r281731 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698