Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 377693005: Revert of Add SkRacy (Closed)

Created:
6 years, 5 months ago by mtklein
Modified:
6 years, 5 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkRacy (https://codereview.chromium.org/371363004/) Reason for revert: hidden symbol 'AnnotateBenignRaceSized' in obj/base/third_party/dynamic_annotations/libdynamic_annotations.a(obj/base/third_party/dynamic_annotations/dynamic_annotations.dynamic_annotations.o) is referenced by DSO lib/libblink_platform.so Original issue's description: > Add SkRacy > > SkRacy<T> is a zero-overhead wrapper for a T, except it also > silences race warnings when TSAN is running. > > Here we apply in several classes. In SkMatrix and SkPathRef, > we use it to opportunistically cache some idempotent work. > > In SkPixelRef, we wrap the genIDs. We think the worst that > can happen here is we'll increment the global next-genID a > few times instead of once when we go to get another ID. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d5e3e6ae1b3434ad1158f441902ff65f1eeaa3a7 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d3f3e5895efb5edfd838ba9127093c804f9dbc12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -63 lines) Patch
M include/core/SkDynamicAnnotations.h View 2 chunks +0 lines, -38 lines 0 comments Download
M include/core/SkMatrix.h View 3 chunks +2 lines, -3 lines 0 comments Download
M include/core/SkPathRef.h View 4 chunks +7 lines, -9 lines 0 comments Download
M include/core/SkPixelRef.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkPathRef.cpp View 3 chunks +12 lines, -10 lines 0 comments Download
M tools/tsan.supp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Add SkRacy
6 years, 5 months ago (2014-07-08 21:05:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/377693005/1
6 years, 5 months ago (2014-07-08 21:06:42 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 21:06:52 UTC) #3
Message was sent while issue was closed.
Change committed as d3f3e5895efb5edfd838ba9127093c804f9dbc12

Powered by Google App Engine
This is Rietveld 408576698