Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: tools/perf/benchmarks/browsermark.py

Issue 377693004: Update browsermark to use results.AddValue(..) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/browsermark.py
diff --git a/tools/perf/benchmarks/browsermark.py b/tools/perf/benchmarks/browsermark.py
index 5ab389fcac00baf753766df905dc8a76ef8c9d2c..a1ff261f100c261ede65f310af1bbd41dc4f1c49 100644
--- a/tools/perf/benchmarks/browsermark.py
+++ b/tools/perf/benchmarks/browsermark.py
@@ -23,6 +23,7 @@ import os
from telemetry import benchmark
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import scalar
class _BrowsermarkMeasurement(page_measurement.PageMeasurement):
@@ -41,7 +42,8 @@ class _BrowsermarkMeasurement(page_measurement.PageMeasurement):
'window.location.pathname.indexOf("results") != -1', 600)
result = int(tab.EvaluateJavaScript(
'document.getElementsByClassName("score")[0].innerHTML'))
- results.Add('Score', 'score', result)
+ results.AddValue(
+ scalar.ScalarValue(results.current_page, 'Score', 'score', result))
@benchmark.Disabled
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698