Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 377683002: Fixes for re-enabling more MSVC level 4 warnings: chrome/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/session_commands.cc
diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc
index 864ffd7fa53459f950b43927aced3df20eac65ca..330a7531567868ccf14354847f60b3486bbd8ebf 100644
--- a/chrome/test/chromedriver/session_commands.cc
+++ b/chrome/test/chromedriver/session_commands.cc
@@ -477,7 +477,8 @@ Status ExecuteSetWindowPosition(
Session* session,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
- double x, y;
+ double x = 0;
+ double y = 0;
if (!params.GetDouble("x", &x) || !params.GetDouble("y", &y))
return Status(kUnknownError, "missing or invalid 'x' or 'y'");
@@ -528,7 +529,8 @@ Status ExecuteSetWindowSize(
Session* session,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
- double width, height;
+ double width = 0;
+ double height = 0;
if (!params.GetDouble("width", &width) ||
!params.GetDouble("height", &height))
return Status(kUnknownError, "missing or invalid 'width' or 'height'");

Powered by Google App Engine
This is Rietveld 408576698