Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 377683002: Fixes for re-enabling more MSVC level 4 warnings: chrome/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc ('k') | chrome/test/chromedriver/chrome/automation_extension.cc » ('j') | chrome/utility/media_galleries/pmp_column_reader_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index d72372bea1cd69c46b6a0b5d2054289dbe582b0d..b30e871d4ba898f70603ca2b36c314b562375457 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -124,9 +124,9 @@ Status ParseMobileEmulation(const base::Value& option,
if (!mobile_emulation->GetDictionary("deviceMetrics", &metrics))
return Status(kUnknownError, "'deviceMetrics' must be a dictionary");
- int width;
- int height;
- double device_scale_factor;
+ int width = 0;
+ int height = 0;
+ double device_scale_factor = 0;
if (!metrics->GetInteger("width", &width) ||
!metrics->GetInteger("height", &height) ||
!metrics->GetDouble("pixelRatio", &device_scale_factor))
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc ('k') | chrome/test/chromedriver/chrome/automation_extension.cc » ('j') | chrome/utility/media_galleries/pmp_column_reader_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698