Fixes for re-enabling more MSVC level 4 warnings: chrome/ edition

chrome/test/chromedriver/element_util.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/element_util.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/platform_thread.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/test/chromedriver/basic_types.h"
 #include "chrome/test/chromedriver/chrome/chrome.h"
 #include "chrome/test/chromedriver/chrome/js.h"
 #include "chrome/test/chromedriver/chrome/status.h"
 #include "chrome/test/chromedriver/chrome/version.h"
 #include "chrome/test/chromedriver/chrome/web_view.h"
 #include "chrome/test/chromedriver/session.h"
 #include "third_party/webdriver/atoms.h"
 
 namespace {
 
 const char kElementKey[] = "ELEMENT";
 
 bool ParseFromValue(base::Value* value, WebPoint* point) {
   base::DictionaryValue* dict_value;
   if (!value->GetAsDictionary(&dict_value))
     return false;
-  double x, y;
+  double x = 0;
+  double y = 0;
   if (!dict_value->GetDouble("x", &x) ||
       !dict_value->GetDouble("y", &y))
     return false;
   point->x = static_cast<int>(x);
   point->y = static_cast<int>(y);
   return true;
 }
 
 bool ParseFromValue(base::Value* value, WebSize* size) {
   base::DictionaryValue* dict_value;
   if (!value->GetAsDictionary(&dict_value))
     return false;
-  double width, height;
+  double width = 0;
+  double height = 0;
   if (!dict_value->GetDouble("width", &width) ||
       !dict_value->GetDouble("height", &height))
     return false;
   size->width = static_cast<int>(width);
   size->height = static_cast<int>(height);
   return true;
 }
 
 bool ParseFromValue(base::Value* value, WebRect* rect) {
   base::DictionaryValue* dict_value;
   if (!value->GetAsDictionary(&dict_value))
     return false;
-  double x, y, width, height;
+  double x = 0;
+  double y = 0;
+  double width = 0;
+  double height = 0;
   if (!dict_value->GetDouble("left", &x) ||
       !dict_value->GetDouble("top", &y) ||
       !dict_value->GetDouble("width", &width) ||
       !dict_value->GetDouble("height", &height))
     return false;
   rect->origin.x = static_cast<int>(x);
   rect->origin.y = static_cast<int>(y);
   rect->size.width = static_cast<int>(width);
   rect->size.height = static_cast<int>(height);
   return true;
@@ skipping 26 matching lines @@
   base::ListValue args;
   args.Append(CreateElement(element_id));
   args.Append(CreateValueFrom(location));
   scoped_ptr<base::Value> result;
   Status status = CallAtomsJs(
       frame, web_view, webdriver::atoms::IS_ELEMENT_CLICKABLE,
       args, &result);
   if (status.IsError())
     return status;
   base::DictionaryValue* dict;
-  bool is_clickable;
+  bool is_clickable = false;
   if (!result->GetAsDictionary(&dict) ||
       !dict->GetBoolean("clickable", &is_clickable)) {
     return Status(kUnknownError,
                   "failed to parse value of IS_ELEMENT_CLICKABLE");
   }
 
   if (!is_clickable) {
     std::string message;
     if (!dict->GetString("message", &message))
       message = "element is not clickable";
@@ skipping 531 matching lines @@
     status = ScrollElementRegionIntoViewHelper(
         rit->parent_frame_id, web_view, frame_element_id,
         WebRect(region_offset, region_size),
         center, frame_element_id, &region_offset);
     if (status.IsError())
       return status;
   }
   *location = region_offset;
   return Status(kOk);
 }