Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/common/spellcheck_marker.h

Issue 377683002: Fixes for re-enabling more MSVC level 4 warnings: chrome/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_SPELLCHECK_MARKER_H_ 5 #ifndef CHROME_COMMON_SPELLCHECK_MARKER_H_
6 #define CHROME_COMMON_SPELLCHECK_MARKER_H_ 6 #define CHROME_COMMON_SPELLCHECK_MARKER_H_
7 7
8 class SpellCheckMarker { 8 class SpellCheckMarker {
9 public: 9 public:
10 // A predicate to test spellcheck marker validity. 10 // A predicate to test spellcheck marker validity.
11 class IsValidPredicate { 11 class IsValidPredicate {
12 public: 12 public:
13 typedef SpellCheckMarker argument_type; 13 typedef SpellCheckMarker argument_type;
14 explicit IsValidPredicate(size_t text_length) : text_length_(text_length) {} 14 explicit IsValidPredicate(size_t text_length) : text_length_(text_length) {}
15 bool operator()(const SpellCheckMarker& marker) const { 15 bool operator()(const SpellCheckMarker& marker) const {
16 return marker.offset < text_length_; 16 return marker.offset < text_length_;
17 } 17 }
18 private: 18 private:
19 size_t text_length_; 19 size_t text_length_;
20 }; 20 };
21 21
22 // IPC requires a default constructor. 22 // IPC requires a default constructor.
23 SpellCheckMarker() : hash(-1), offset(-1) {} 23 SpellCheckMarker() : hash(0xFFFFFFFF), offset(static_cast<size_t>(-1)) {}
24 24
25 SpellCheckMarker(uint32 hash, size_t offset) : hash(hash), offset(offset) {} 25 SpellCheckMarker(uint32 hash, size_t offset) : hash(hash), offset(offset) {}
26 26
27 uint32 hash; 27 uint32 hash;
28 size_t offset; 28 size_t offset;
29 }; 29 };
30 30
31 #endif // CHROME_COMMON_SPELLCHECK_MARKER_H_ 31 #endif // CHROME_COMMON_SPELLCHECK_MARKER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698