Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 377563002: [SyncFS] Eliminate SyncFileSystemService dependency from SyncProcessRunner (Closed)

Created:
6 years, 5 months ago by tzik
Modified:
6 years, 5 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Eliminate SyncFileSystemService dependency from SyncProcessRunner Eliminate SyncFileSystemService from SyncProcessRunner to inject its dependency from tests. BUG=344769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -39 lines) Patch
M chrome/browser/sync_file_system/sync_file_system_service.h View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 8 chunks +32 lines, -28 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.h View 4 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.cc View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
PTL
6 years, 5 months ago (2014-07-07 14:36:03 UTC) #1
peria
lgtm
6 years, 5 months ago (2014-07-08 02:16:39 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 5 months ago (2014-07-08 03:40:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/377563002/1
6 years, 5 months ago (2014-07-08 03:41:22 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 06:34:35 UTC) #5
Message was sent while issue was closed.
Change committed as 281680

Powered by Google App Engine
This is Rietveld 408576698